Use CSSnumericValue.parse() when parsing range start and end #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesodland
force-pushed
the
parse-calc-in-range-attributes
branch
from
e0f0826 to
4732d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #176, #177 and #178.
This PR uses
CSSNumericValue.parse()to parse string values for range start and range end.This adds support for math functions such as
calc(100% - 20px).The PR includes
– Naive implementation of
CSSNumericValue.parse()in proxy-cssom.js.This PR does not include:
– Support for relative units such as *vh in the calculations. This must be added in a separate PR.