Disable effect without cancelling animation #179
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timeline is inactive, the current implementation disables the effect by cancelling the underlying animation.
This can cause issues. If the animation is later cancelled "for real" the animation is already idle and no
cancel
event will be emitted.One example of code that is affected is the WPT subtest 'oncancel event is fired when the timeline is inactive.' in cancel-animation.html.
This test will time out if the timeline is updated when the source style is changed.
The polyfill currently don't detect style changes, and fails at the sanity check,
but in the future (PR #177) I expect that we will react to style changes.
This PR tries to work around the issue by temporary removing the effect, instead of cancelling the animation, when the timeline is inactive.