-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Great Pcode Extractor Refactoring #472
Draft
vobst
wants to merge
88
commits into
fkie-cad:master
Choose a base branch
from
vobst:pcode_extractor_refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
June 20, 2024 08:30
16a9df3
to
1a790e8
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
July 5, 2024 21:32
1a790e8
to
9fe7810
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
2 times, most recently
from
July 23, 2024 21:16
084f839
to
3b7311b
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
2 times, most recently
from
August 13, 2024 15:22
f1c0c5c
to
4377297
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
August 20, 2024 07:24
4377297
to
31625be
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
September 13, 2024 16:45
31625be
to
653602c
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
September 27, 2024 08:05
653602c
to
8535d44
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
October 16, 2024 16:50
8535d44
to
0e0a73b
Compare
Replace the Pcode Extractor plugin with a stripped-down version that is not doing any processing. Its job is just to obtain the relevant data from the Ghidra APIs and to hand it over to the Rust side, where all of the processing will be done.
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
October 30, 2024 10:15
d8c4f96
to
e092a4e
Compare
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
October 30, 2024 10:38
e092a4e
to
bf62f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: While in draft state, this PR will be force pushed without notice.
tl;dr: The goal of this PR is to simplify the Ghidra plugin by moving all of the pcode transformations to the Rust side.