Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #1229

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Dark Mode #1229

wants to merge 7 commits into from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jun 27, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (42f7320) to head (6d86655).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   91.96%   91.88%   -0.08%     
==========================================
  Files         377      376       -1     
  Lines       22360    20949    -1411     
==========================================
- Hits        20564    19250    -1314     
+ Misses       1796     1699      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 27, 2024

pr_review_0
table has not-nice looking padding to the right

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 27, 2024

pr_review_1
The hyper links / references should be highlighted more prominently

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 27, 2024

pr_review_2
Line Numbering should be light, probably white

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 27, 2024

pr_review_3
Was it a concious decision to give these tables a background? I'm not sure, but I think I'd prefer it not having the background differ from the rest of the "dark" back.

@jstucke
Copy link
Collaborator Author

jstucke commented Nov 27, 2024

pr_review_0 table has not-nice looking padding to the right

fun fact: this problem was not introduced by this PR -- it was just invisible 😅

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 27, 2024

pr_review_4
Probably tough, but it would surely be nice to make the pacman look more smooth on the dark background

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 27, 2024

pr_review_5
Labels are tough to read. Should be light.

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 28, 2024

pr_review_6
This is also impractical. The file name is not really readable. Either font would have to be dark or highlighting would have to be darker.

@jstucke
Copy link
Collaborator Author

jstucke commented Dec 2, 2024

pr_review_1 The hyper links / references should be highlighted more prominently

it seems colored links were at least partially disabled in FACT at some point (independent of dark mode). Do we want to change that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants