Mypy: fix helper functions #1224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstucke
force-pushed
the
mypy-helperfunctions
branch
3 times, most recently
from
ffafaf1 to
6af6f0b
Compare
jstucke
force-pushed
the
mypy-helperfunctions
branch
from
6af6f0b to
235e8dd
Compare
jstucke
force-pushed
the
mypy-helperfunctions
branch
from
235e8dd to
d89f92f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
- Coverage 92.50% 91.83% -0.67%
==========================================
Files 381 376 -5
Lines 24219 21026 -3193
==========================================
- Hits 22404 19310 -3094
+ Misses 1815 1716 -99 ☔ View full report in Codecov by Sentry. |
jstucke
force-pushed
the
mypy-helperfunctions
branch
from
58d285b to
eb19521
Compare
|
In an effort to separate commits that actually change codes from commits that only change type hints, I added 41e36ac. Would you mind improving the commit message (at least removing the WIP prefix)? |
jstucke
force-pushed
the
mypy-helperfunctions
branch
from
eb19521 to
198e304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1123 and #1142
pyproject.tomlhelperFunctionsthis does not include the pre-commit hook yet (otherwise all other builds would fail after merging this PR)