Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility with OGIP datasets #81

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Conversation

fjebaker
Copy link
Owner

Forward all the kwargs

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 67.20%. Comparing base (0dc8ea7) to head (975a183).
Report is 1 commits behind head on main.

Files Patch % Lines
src/datasets/mission-specifics.jl 26.31% 14 Missing ⚠️
src/datasets/ogip.jl 65.51% 10 Missing ⚠️
src/datasets/ogipdataset.jl 66.66% 2 Missing ⚠️
src/datasets/spectraldata.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   68.38%   67.20%   -1.19%     
==========================================
  Files          40       39       -1     
  Lines        1996     2000       +4     
==========================================
- Hits         1365     1344      -21     
- Misses        631      656      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjebaker fjebaker merged commit f5c48b0 into main Feb 26, 2024
1 of 3 checks passed
@fjebaker fjebaker deleted the fergus/ogip-flexibility branch February 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants