Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework model API and reflection #104

Merged
merged 8 commits into from
May 21, 2024
Merged

Rework model API and reflection #104

merged 8 commits into from
May 21, 2024

Conversation

fjebaker
Copy link
Owner

No description provided.

fjebaker added 8 commits May 20, 2024 21:21
This marks the commit where the test suite is fully working again after
removing the `FunctionGeneration` module and replacing it with a much
more lightweight and efficient `Reflection` module.

The model API now as an explicit test, so that we make sure to not break
the stable API.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.31373% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 66.00%. Comparing base (14efcdd) to head (022d33f).
Report is 79 commits behind head on main.

Files Patch % Lines
src/composite-models.jl 64.91% 20 Missing ⚠️
src/reflection.jl 91.87% 13 Missing ⚠️
src/support.jl 67.85% 9 Missing ⚠️
src/abstract-models.jl 90.32% 3 Missing ⚠️
src/fitting/problem.jl 0.00% 2 Missing ⚠️
src/datasets/spectrum.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   65.37%   66.00%   +0.63%     
==========================================
  Files          39       41       +2     
  Lines        2010     2171     +161     
==========================================
+ Hits         1314     1433     +119     
- Misses        696      738      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjebaker fjebaker merged commit 70eea68 into main May 21, 2024
3 checks passed
@fjebaker fjebaker deleted the fergus/model-api branch May 21, 2024 13:48
@fjebaker fjebaker mentioned this pull request May 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants