Fixed height calculations when using padding #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiznool
reviewed
Nov 14, 2017
|
|
||
| constructor( | ||
| private element: ElementRef, | ||
| private ngZone: NgZone, | ||
| @Optional() private model: NgModel | ||
| ) {} | ||
| ) { } |
There was a problem hiding this comment.
Please could you recommit without the extra whitespace?
fiznool
reviewed
Nov 14, 2017
|
|
||
| ngOnInit() { | ||
| if(!this.model) { | ||
| if (!this.model) { |
fiznool
requested changes
Nov 14, 2017
| @@ -30,7 +31,7 @@ export class ElasticDirective implements OnInit, OnDestroy, AfterViewInit { | |||
| } | |||
|
|
|||
| ngOnDestroy() { | |||
| if(this.modelSub) { | |||
| if (this.modelSub) { | |||
| @@ -87,6 +92,6 @@ export class ElasticDirective implements OnInit, OnDestroy, AfterViewInit { | |||
| } | |||
|
|
|||
| this.textareaEl.style.height = 'auto'; | |||
| this.textareaEl.style.height = this.textareaEl.scrollHeight + "px"; | |||
| this.textareaEl.style.height = this.textareaEl.scrollHeight - this.totalVerticalPadding + "px"; | |||
There was a problem hiding this comment.
The most recent commit uses a backtick string so let's do the same here.
| const paddingTop = window.getComputedStyle(this.textareaEl).getPropertyValue('padding-top').replace('px', ''); | ||
| const paddingBottom = window.getComputedStyle(this.textareaEl).getPropertyValue('padding-bottom').replace('px', ''); | ||
| this.totalVerticalPadding = +paddingTop + +paddingBottom; | ||
|
|
There was a problem hiding this comment.
I'd prefer to make a few changes here.
- Let's cache the result of
getComputedStylein a variable so it isn't calculated twice. - Let's use
parseInt()instead of the unary+operator, as this is consistent with elsewhere in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrollHeightincludes padding, normal element height does not. This commit fixes that problem by subtracting the padding when setting height.getComputedStylealways returns the unit in pixels, so the code should still work even if you're usingemorremas your padding unit.