Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge latest Osheroff branch for MariaDB GTID support #3

Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

Merge latest Osheroff branch for MariaDB GTID support #3

wants to merge 77 commits into from

Conversation

fivetran-mattalexander
Copy link

No description provided.

jackey.zhang and others added 30 commits July 13, 2021 11:39
Adding support Mariadb events, such as GTID and annotate rows event(sql)
3598de7
@wingerx
refact to support mariadb types
1f27791
@wingerx
add some doc informations about mariadb
486a447
@osheroff
Merge remote-tracking branch 'origin/master' into wingerx/master
8123277
@osheroff
fixup javadoc stuff
1c21400
@osheroff
can we build under maria?
67a840e
@osheroff
see about running tests
5d4c0fd
@osheroff
streamline a touch
fbc9c73
@osheroff
oh java
f2ea85c
@osheroff
add --debug
85840c3
@osheroff
bump
6247519
@osheroff
maria fixes in JSON land
988750e
@osheroff
can maven be quiet plz?
492c6a4
@osheroff
abstract out some tests, shuffle around maria-specific stuff
7c52c0a
@osheroff
refactor: bring mariaDB back into the mainline path
2ae2eb8 
no need to know what sever you're connecting to.  we can figure it out.

Also, these tests never worked.  fix them.
@osheroff
update README
9e19267
@osheroff
checkpoint
420d192
@osheroff
pre-3
6690878 
This resolves the current/historical split and parses the flags
@osheroff
Merge pull request shyiko#79 from osheroff/osheroff/mariadb_gtid
8f32e1e 
mariadb -- gtid support
@osheroff
0.27.0
4c83012
@osheroff
update CHANGELOG
c6ab6e0
@osheroff
fix test speed
2e4686f
@osheroff
correct mariadb_slave_capability value
eaa9e56 
I think it's fair to say we understand ANNOTATE_ROWS_EVENT, but none of
the other stuff represented by this variable is true.
@osheroff
Merge pull request shyiko#80 from osheroff/correct_capability
96446c5 
correct mariadb_slave_capability value
@osheroff
update changelog
faed360
@osheroff
0.27.1
2774bed
@osheroff
implement a better regex for detecting mariadb gtid strs
d76c7ee
@osheroff
Merge pull request shyiko#82 from osheroff/more_reliable_gtid
2e65351 
implement a better regex for detecting mariadb gtid strs
@osheroff
0.27.2
1c6b8f9
@osheroff
pass useSendAnnotate etc through non-gtid commands
2ea9f6c
mvelliste and others added 27 commits November 16, 2022 13:40
@mvelliste @fivetran-mattalexander
Updated version
a8f584b
@mvelliste @fivetran-mattalexander
Added json null test
05ac2e5
@mvelliste @fivetran-mattalexander
version++
48c75b3
@georgewfraser @fivetran-mattalexander
TLSHostnameVerifier uses no longer available API
7bf4e4f
@glarwood @fivetran-mattalexander
refactor(BinaryLogClient): make binlogChecksum related methods/fields…
c73f9ce 
… protected
@glarwood @fivetran-mattalexander
refactor(BinaryLogClient): manually undo fd9f033 to simplify upstream…
d06003d 
… merge
@glarwood @fivetran-mattalexander
fix(ByteArrayOutputStream): use composed OutputStream#write
b0370a9
@fivetran-ellen @fivetran-mattalexander
specified year zero condition
336b771
@glarwood @fivetran-mattalexander
fix(AbstractRowsEventDataDeserializer): add microsecond precision for…
cdabe05 
… datetime/timestamp
@glarwood @fivetran-mattalexander
fix(AbstractRowsEventDataDeserializer): add microsecond precision for…
7b8bba4 
… time
@fivetran-mattalexander
Add AURORA_PADDING event types and refactor event types to no longer …
6b3bb72 
…use an enum ordinal to resolve event type IDs
@fivetran-mattalexander
Make event id private and final
dfa9de1
@fivetran-shivavanamala @fivetran-mattalexander
Create unknown event type for invalid and proprietary event types. Re…
30987eb 
…moved AURORA_PADDING event type.
@fivetran-shivavanamala @fivetran-mattalexander
Removed AURORA_PADDING event
c7c70fd
@fivetran-shivavanamala @fivetran-mattalexander
Changed the way unknown event type is being created
c11cb2e 
EventType.forId(0) -> EventType.UNKNOWN
@fivetran-shivavanamala @fivetran-mattalexander
EventType.forId() returns EventType.UNKNOWN if invalid eventId is pas…
41fc68b 
…sed.
@fivetran-shivavanamala @fivetran-mattalexander
refactor: Removed redundant single line function
4e3ac3c
@zekail @fivetran-mattalexander
feature(table_map_event_data_serializer): add support of ColumnVisibi…
256fd4a 
…lity metadata and handle unknown metadata field type
@zekail @fivetran-mattalexander
fix(table_map_event_data_serializer): skip deserializing the table ma…
c835a5b 
…p event when the stream is empty
@zekail @fivetran-mattalexander
fix(table_map_event_data_serializer): log a message when skipping des…
f0f73e3 
…erializing the table map event
@IG-ReDCAD @fivetran-mattalexander
fix for json parsing error
cfe843e
@fivetran-mattalexander
Fork BinaryLogClient to FF abortRequest change
710f48b
@jmlw @fivetran-mattalexander
cleanup(mysql): [T-252649] consolidate new abort logic
ecd7088
@ashleycoxley @fivetran-mattalexander
re-add abort logic on its own (without old deadlock fix)
c9186f0
@ashleycoxley @fivetran-mattalexander
add client identity method
655337d
@fivetran-mattalexander
Fix merge errors
812e3a9
@fivetran-mattalexander
Fix isContainedWithin to correctly return True when positions are equ…
8fba192 
…ivalent
@fivetran-mattalexander
Copy link
Author

The only merge conflicts I believe I ran into were in EventType: https://github.com/fivetran/mysql-binlog-connector-java-osheroff/pull/3/files#diff-7b945f6591af097de7a693dca3d77421ed07523a1f3b37c707920146e90986cd

ashleycoxley
ashleycoxley reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@ashleycoxley ashleycoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to add this!

The only thing that gives me pause is the version bumps on the Jackson libraries - I'm having trouble thinking through whether it'll interact badly with the (2.9) Jackson libraries in the engineering repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleycoxley ashleycoxley ashleycoxley left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.