Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#139 Fix systemd not running #141

Conversation

forsthug
Copy link
Contributor

@forsthug forsthug commented Dec 19, 2023

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

{Summary of the changes}

Description

{Detail}

Fixes #{issue number}

@forsthug forsthug requested a review from a team as a code owner December 19, 2023 09:57
volllly
volllly previously approved these changes Jan 3, 2024
@@ -28,6 +32,27 @@ public static IHostBuilder UseCustomHostLifetime(this IHostBuilder builder)
#pragma warning restore CA1416
});
}
else if (isSystemd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know/have you tried using SystemdHelpers.IsSystemdService()? That would be a bit easier and cleaner I think 😁

@volllly volllly dismissed their stale review January 3, 2024 14:04

missclick

@volllly volllly changed the title #100 - Keyring dataprotection does not work when run as a linux service #139 - Error installing launcher twice Jan 3, 2024
@volllly volllly changed the title #139 - Error installing launcher twice Error installing launcher twice Jan 3, 2024
@volllly volllly changed the title Error installing launcher twice Improve systemd handling Jan 3, 2024
@forsthug forsthug marked this pull request as draft January 4, 2024 09:00
@forsthug forsthug changed the title Improve systemd handling #139 Fix systemd not running Jan 11, 2024
@forsthug forsthug marked this pull request as ready for review January 11, 2024 10:19
@forsthug forsthug closed this Jan 12, 2024
@forsthug forsthug deleted the #100-Keyring-dataprotection-does-not-work-when-run-as-a-linux-service branch January 12, 2024 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing launcher twice
2 participants