Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background of the station name now matches the color of the list item #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahitech
Copy link

@ahitech ahitech commented Jul 1, 2018

The station data in the list view always had a gray background; this was the result of choosing B_MENU_BACKGROUND_COLOR as the only possible low color for the BView. I've modified one line (line 55) according to the line 51. Now background of the station name and other data will match the background color of the BListItem.

Small change, more a tweak than a bugfix, but makes the application more pleasant to the eye.

I don't know the reason for changes in other lines, I didn't touch them.

Copy link
Author

@ahitech ahitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the only change

@scottmc
Copy link

scottmc commented Sep 7, 2018

You somehow made whitespace changes. Perhaps redo the diff and only change that single line, then verify you only changed that line by running git diff before committing it. It's likely your editor settings did it.

@humdingerb
Copy link

I think @fishpond-haiku isn't that active at the moment.
He agreed to HaikuArchives forking and further develop the app. This PR may be better sent to https://github.com/HaikuArchives/Haiku-Radio instead.

@scottmc
Copy link

scottmc commented Sep 7, 2018

Ah yes, it's at HaikuArchives now. Yes please open a new pull request for it there being sure it only changes that singe line and doesn't make whitespace changes.

@fishpond-haiku
Copy link
Owner

fishpond-haiku commented Sep 7, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants