Fixing scrutinizer issues re unneeded variables secret and status_mfa

fisharebest · Nov 20, 2024 · 6dce555 · 6dce555
1 parent 68eb190
commit 6dce555
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/app/Http/RequestHandlers/RegisterAction.php b/app/Http/RequestHandlers/RegisterAction.php
@@ -96,14 +96,13 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         $password = Validator::parsedBody($request)->string('password');
         $realname = Validator::parsedBody($request)->string('realname');
         $username = Validator::parsedBody($request)->string('username');
-        $secret   = Validator::parsedBody($request)->string('secret');
 
         try {
             if ($this->captcha_service->isRobot($request)) {
                 throw new Exception(I18N::translate('Please try again.'));
             }
 
-            $this->doValidateRegistration($request, $username, $email, $realname, $comments, $password, $secret);
+            $this->doValidateRegistration($request, $username, $email, $realname, $comments, $password);
 
             Session::forget('register_comments');
             Session::forget('register_email');
@@ -249,8 +248,7 @@ private function doValidateRegistration(
         string $email,
         string $realname,
         string $comments,
-        #[\SensitiveParameter] string $password,
-        string $secret
+        #[\SensitiveParameter] string $password
     ): void {
         // All fields are required
         if ($username === '' || $email === '' || $realname === '' || $comments === '' || $password === '') {

diff --git a/app/Http/RequestHandlers/UserAddAction.php b/app/Http/RequestHandlers/UserAddAction.php
@@ -59,7 +59,6 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         $real_name = Validator::parsedBody($request)->string('real_name');
         $email     = Validator::parsedBody($request)->string('email');
         $password  = Validator::parsedBody($request)->string('password');
-        $secret    = "";
 
         $errors = false;
 

diff --git a/app/Http/RequestHandlers/UserEditAction.php b/app/Http/RequestHandlers/UserEditAction.php
@@ -75,7 +75,6 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         $real_name      = Validator::parsedBody($request)->string('real_name');
         $email          = Validator::parsedBody($request)->string('email');
         $password       = Validator::parsedBody($request)->string('password');
-        $secret         = Validator::parsedBody($request)->string('secret');
         $theme          = Validator::parsedBody($request)->string('theme');
         $language       = Validator::parsedBody($request)->string('language');
         $timezone       = Validator::parsedBody($request)->string('timezone');
@@ -85,7 +84,6 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         $canadmin       = Validator::parsedBody($request)->boolean('canadmin', false);
         $visible_online = Validator::parsedBody($request)->boolean('visible-online', false);
         $verified       = Validator::parsedBody($request)->boolean('verified', false);
-        $status_mfa     = Validator::parsedBody($request)->boolean('status-mfa', false);
         $approved       = Validator::parsedBody($request)->boolean('approved', false);
 
         $edit_user = $this->user_service->find($user_id);