genesis block --- or mergable by default #352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchris
commented
Dec 10, 2024
| @@ -45,7 +46,7 @@ describe("dreamcode", function () { | |||
| }); | |||
| beforeEach(async function () { | |||
| await sthis.start(); | |||
| db = fireproof("test-db"); | |||
| db = fireproof("test-db", { public: true }); | |||
There was a problem hiding this comment.
this is not the correct way to configure public:true but we should probably make this work instead of requiring the keyname trick
|
In series_0.20 the url's are preprocessed there we could map public into
key=insecure.
…On Tue, Dec 10, 2024 at 8:04 AM Chris Anderson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/fireproof/fireproof.test.ts
<#352 (comment)>
:
> @@ -45,7 +46,7 @@ describe("dreamcode", function () {
});
beforeEach(async function () {
await sthis.start();
- db = fireproof("test-db");
+ db = fireproof("test-db", { public: true });
this is not the correct way to configure public:true but we should
probably make this work instead of requiring the keyname trick
—
Reply to this email directly, view it on GitHub
<#352 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEWJXLABYMOW77HAAD7TL2E3RGBAVCNFSM6AAAAABRZWNCACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJSGI3DINZSGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test that two differently originated databases can merge.