Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix unsupported math functions #57

Merged
merged 1 commit into from
Aug 12, 2024
Merged

tests: Fix unsupported math functions #57

merged 1 commit into from
Aug 12, 2024

Conversation

stepansergeevitch
Copy link
Collaborator

Disabled math function that are not supported by Firebolt

@stepansergeevitch stepansergeevitch self-assigned this Jul 31, 2024
@stepansergeevitch stepansergeevitch requested a review from a team as a code owner July 31, 2024 11:48
ptiurin
ptiurin approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, but some of the functions are suported by Firebolt, e.g. ABS or POW. Is there a more fine-grained flag?

@stepansergeevitch
Copy link
Collaborator Author

Generally lgtm, but some of the functions are suported by Firebolt, e.g. ABS or POW. Is there a more fine-grained flag?

AFAIK no, you either support all or none

@stepansergeevitch stepansergeevitch merged commit da37290 into develop Aug 12, 2024
2 checks passed
@stepansergeevitch stepansergeevitch deleted the FIR-35110-unknown-math-functions branch August 12, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin