ci: Integration tests against Firebolt 2.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
force-pushed
the
ci-2.0
branch
from
e21c1a7 to
9a7ce98
Compare
ptiurin
approved these changes
Jul 29, 2024
| firebolt-client-secret: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }} | ||
| account: ${{ vars.FIREBOLT_ACCOUNT }} | ||
| api-endpoint: "api.staging.firebolt.io" | ||
| instance-type: "M" |
There was a problem hiding this comment.
Do we actually need an M-sized engine for metabase testing?
There was a problem hiding this comment.
I had some issues where engine reported lack of memory in some cases. That's why I had to update the engine size
Comment on lines
+77
to
+86
| - name: Publish Test Report (JUnit) | ||
| uses: dorny/test-reporter@v1 | ||
| if: failure() | ||
| with: | ||
| path: 'target/junit/**/*_test.xml' | ||
| name: Firebolt 2.0 Metabase driver JUnit Test Report | ||
| reporter: java-junit | ||
| list-suites: failed | ||
| list-tests: failed | ||
| fail-on-error: false |
There was a problem hiding this comment.
We can probably replace it with Allure later on, since it supports JUnit. This way we'll have the reporting standardised across Ecosystem. Let's file a ticket so we don't forget.
There was a problem hiding this comment.
Sure, sounds good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added