Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes non-cmake build issues for macOS #26

Closed
wants to merge 1 commit into from
Closed

fixes non-cmake build issues for macOS #26

wants to merge 1 commit into from

Conversation

kozyilmaz
Copy link
Contributor

fixes two issues for non-cmake builds on macOS:

  • adds CUSTOM_INCLUDEDIR and CUSTOM_LIBDIR params for specifying custom dependency paths
  • removes unsupported --version-script=lib.lds, --no-undefined, -Bstatic and -Bdynamic linker flags

@kozyilmaz
fixes two issues for non-cmake builds on macOS:
62673eb 
- adds CUSTOM_INCLUDEDIR and CUSTOM_LIBDIR params for specifying custom dependency paths
- removes unsupported --version-script=lib.lds, --no-undefined, -Bstatic and -Bdynamic linker flags

Signed-off-by: kozyilmaz <[email protected]>
@kozyilmaz
Copy link
Contributor Author

without -Bstatic and -Bdynamic definitions *nix build seems to be confused. Closing due to high modifications, will try to upstream cmakebuild for macOS

@kozyilmaz kozyilmaz closed this May 20, 2024
@kozyilmaz kozyilmaz deleted the macos-make branch May 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kozyilmaz