Firestore: Remove obsolete NOLINT comments #14347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4, build/c++tr1, build/namespaces_literals
dconeybe
force-pushed
the
dconeybe/CppLintRemoveObsoleteNoLintComments
branch
from
96fd28a to
605d689
Compare
cherylEnkidu
requested changes
Jan 17, 2025
cherylEnkidu
approved these changes
Jan 20, 2025
|
I think this broken the |
|
Hi @dconeybe, does the above suggestion make sense to you? |
Possibly, yes. It looks like the "lint" check tries to be smart and only scan files that have "changed". I must have changed those files in this PR but not run the lint check. I'll open a PR to fix this. It's trivial. |
|
Opened #14374 to fix the lint errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
NOLINTcomments from the code base that are obsolete as of #14320, which deleted obsolete c++11 and c++14 lint checks.#no-changelog