Firestore: Skip StringFormatTest.Pointer, to work around ASAN test failures #14327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used by GTEST_SKIP: error: code will never be executed [-Werror,-Wunreachable-code]
|
There is no point in disabling the one test that explicitly exercises the use-after-free issue because many tests will intermittently crash due to this issue in their indirect exercise of the use-after-free issue. Here is an example: #14306 (comment) |
dconeybe
deleted the
dconeybe/StringFormatStringifySinkUseAfterFreeTemporaryTestDisable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Firestore unit test "StringFormatTest.Pointer" uncovers a use-after-free bug in the Firestore SDK, which causes the Address Sanitizer tests to fail. This PR skips the test to make the tests happy, as the bug will be fixed by #14306 but that PR is taking longer to review and merge than expected.
#no-changelog