refactor: Optimize success count calculation in BatchResponse #837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
This PR refactors the
BatchResponse
class to optimize the calculation ofsuccess_count
. The original implementation used a list comprehension to filter successful responses, which could be inefficient for large datasets. This has been replaced with a generator expression, which improves memory efficiency and maintains clarity.No public API changes have been made. This change only affects the internal logic of the
BatchResponse
class.Testing
API Changes
This change does not affect the public API. It only optimizes internal logic for better performance and readability.