Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimize success count calculation in BatchResponse #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mingi3314
Copy link

Discussion

This PR refactors the BatchResponse class to optimize the calculation of success_count. The original implementation used a list comprehension to filter successful responses, which could be inefficient for large datasets. This has been replaced with a generator expression, which improves memory efficiency and maintains clarity.

No public API changes have been made. This change only affects the internal logic of the BatchResponse class.

Testing

  • Verified that all existing tests in the repository pass successfully after the change.
  • As this is a refactor with no change to external behavior, no additional tests were required.

API Changes

This change does not affect the public API. It only optimizes internal logic for better performance and readability.

Copy link

google-cla bot commented Dec 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mingi3314 mingi3314 force-pushed the refactor-batch-response branch from 796d166 to 276fd53 Compare December 6, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant