Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More integration test for account defender #1684

Draft
wants to merge 4 commits into
base: recaptcha
Choose a base branch
from

Conversation

Xiaoshouzi-gh
Copy link
Contributor

Added more integration test for account defender -
Case 1 - Trying to disable recaptcha after account defender is enabled should return invalid-config error. This is tested by this PR.
Case 2 - Trying to enable account defender when recaptcha is not enabled should return recaptcha-not-enabled error. This is tested by a previous approved change.

This PR is in draft mode because test needs to be verified after RestAPI is ready.

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants