remove workarounds #284
Open
remove workarounds #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggarber are those safe to remove? |
|
@eakraly ^^ |
|
force-rebased ;) |
fippo
commented
Mar 24, 2020
| delete data[2].constraintsOptional; | ||
| } | ||
| tempStream.write(JSON.stringify(data) + '\n'); | ||
| break; | ||
| default: | ||
| if (data[0] === 'getstats' && data[2].values) { // workaround for RtcStats.java bug. |
There was a problem hiding this comment.
i also wonder about that one...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes two obsolete workarounds added in
3340a69
and
4545963