Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Morphir IR in Scala 3 (#97) #102

Closed
wants to merge 2 commits into from
Closed

Model Morphir IR in Scala 3 (#97) #102

wants to merge 2 commits into from

Conversation

AttilaMihaly
Copy link
Member

Co-authored-by: willms2021 [email protected]

* Adding IR - #75

* Adding Package related IR types

* issue-94: add tuple to sdk (#98)

* issue-94: add tuple to sdk

* issue-94: run formatter

* Finishing up modeling of morphir IR in Scala 3

* Move IR into morphir-ir

Co-authored-by: willms2021 <[email protected]>
@AttilaMihaly
Copy link
Member Author

@DamianReeves, I opened this PR because I wanted to rename the default branch to main but saw that there was one already. It seems to be failing though. Are the changes on the main branch production ready?

* issue-94: add tuple to sdk (#98)

* issue-94: add tuple to sdk

* issue-94: run formatter

* Fixed bug. #99 (#100)

Co-authored-by: willms2021 <[email protected]>
Co-authored-by: Attila Mihaly <[email protected]>
@finos-cla-bot
Copy link

finos-cla-bot bot commented Dec 27, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@DamianReeves).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email [email protected] for any questions.

cc @maoo @TheJuanAndOnly99 @mcleo-d

@AttilaMihaly AttilaMihaly deleted the main branch April 22, 2022 10:38
DamianReeves added a commit that referenced this pull request May 25, 2022
* ToString changes for recursive Type

* Fix toString on recursive Type

* Provide more overloads for the reference constructor for recursive style Types

* Fix some constructor usage to unify nonrecursive with recursive

* Apply compatible tuple related change

* Working on switching Value IR back to a recursion schemes based encoding

* Provide fold and mapAttributes implementations

* Add other fold merhods to recursive Value

* Add collectVariables

* Add spec for recursive values

* Add collectReferences to the recursive value

* Add toRawValue

* Added foldLeft

* Apply Scala fix

* Apply fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants