Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A function to clear all previously added objects to the GameArena. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

A function to clear all previously added objects to the GameArena. #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions GameArena.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,15 @@ public void removeText(Text t)
this.removeObject(t);
}

/**
* Removes every object that has ever been added to the GameArena. Nothing
* should appear on the GameArena window after this has executed.
*/
public void clearGameArena() {
things.clear();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think we should protect this code with a synchronized block though. This would prevent the list of objects being cleared during the time that the list is iterated over by the draw() method. I suspect we would get a crash if the user cleared the list during this time.

Could you add a synchronized block around this line, like we do when adding an object:
https://github.com/finneyj/GameArena/blob/master/GameArena.java#L311

If you can add that, and quickly test that it works OK on your code, I'll happily merge this in. :)

}


/**
* Pause for a 1/50 of a second.
* This method causes your program to delay for 1/50th of a second. You'll find this useful if you're trying to animate your application.
Expand Down