Skip to content

Commit

Permalink
Comment
Browse files Browse the repository at this point in the history
Signed-off-by: Finn Carroll <[email protected]>
  • Loading branch information
finnegancarroll committed Aug 23, 2024
1 parent 1103fbb commit 59d9765
Showing 1 changed file with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,10 @@
*/
public class FetchSearchResultsSerDe implements SerDe.StreamSerializer<FetchSearchResult>, SerDe.StreamDeserializer<FetchSearchResult> {
/**
* TODO NOTE: FetchSearchResult inheritance structure is as follows.
* NOTE: FetchSearchResultSerDe should mirror class inheritence strucutre.
* TransportMessage -> TransportResponse -> SearchPhaseResult -> FetchSearchResult.
* Serialization of parent classes is currently a no-op.
* For completeness these parent classes should be mirrored here respectively with:
* TransportMessageSerDe, TransportResponseSerDe, SearchPhaseResultSerDe.
* However, currently only SearchHitsSerDe is needed for serialization.
*
* This is implicitely enforced by FetchSearchResult as well on the serialization side.
* writeTo doesn't call a parent implementation...
* Serialization of parent classes is currently a no-op so leaving as is for now.
*/
SearchHitsSerDe searchHitsSerDe;

Expand Down

0 comments on commit 59d9765

Please sign in to comment.