Fix #257 Frame aliasing @graph with omitGraph=true
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filip26
reviewed
Nov 18, 2023
There was a problem hiding this comment.
I'm not sure about this result, please check that
There was a problem hiding this comment.
If you disable Compact Arrays in JSON-LD Playground you also get a "data" array.
I assumed that Compact Arrays is the equivalent to our omitGraph.
I can add a test case with omitGraph = true if you want
|
It's about time to release a new version. The fix will be available in maven-central soon. |
hmottestad
added a commit
to HASMAC-AS/hasmac-json-ld
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257