Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

convert l1 timing headers into otel spans #158

Merged
merged 2 commits into from
Sep 12, 2023
Merged

convert l1 timing headers into otel spans #158

merged 2 commits into from
Sep 12, 2023

Conversation

willscott
Copy link
Contributor

should allow for validation in tracing ux

@willscott willscott requested a review from guanzo September 11, 2023 13:26
@guanzo
Copy link
Contributor

guanzo commented Sep 11, 2023 •
edited
Loading

Could we add a "cacheHit" attribute (L1 response header is Saturn-Cache-Status) to the span so we can differentiate if the server timings are for this request or a previous request? Assuming that's viewable/filterable in Honeycomb.

@willscott
Copy link
Contributor Author

done

@willscott willscott merged commit 078dddd into main Sep 12, 2023
7 checks passed
@willscott willscott deleted the feat/timing-otel branch September 12, 2023 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guanzo guanzo guanzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willscott @guanzo