This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Instrument response read failures #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aarshkshah1992
commented
Jun 6, 2023
•
aarshkshah1992
commented
- Instrument/logging around range requests % and response read failures
- Ability to experiment by only using core Saturn nodes
willscott
reviewed
Jun 6, 2023
pool.go
Outdated
| tierMainToUnknown = "main-to-unknown" | ||
| tierUnknownToMain = "unknown-to-main" | ||
| BackendOverrideKey = "CABOOSE_BACKEND_OVERRIDE" | ||
| SaturnOrchUrlEnvKey = "CORE_ONLY" |
There was a problem hiding this comment.
this is only used in caboose.go and should be declared there.
caboose.go
Outdated
Comment on lines
211
to
216
| u := DefaultOrchestratorEndpoint | ||
| if v := os.Getenv(SaturnOrchUrlEnvKey); len(v) > 0 { | ||
| u = DefaultOrchestratorCoreEndpoint | ||
| } | ||
|
|
||
| c.config.OrchestratorEndpoint, err = url.Parse(u) |
There was a problem hiding this comment.
why are we adding additional complexity here? we already have an env variable to set OrchestratorEndpoint - why wouldn't we pass in the custom 'core only' orchestrator endpoint that way ,versus this pair of over-rides?
in practice, orchestrator is, i think, set in bifrost-gateway which woudl mean neither of these over-rides would take effect?
There was a problem hiding this comment.
Oh right. I agree. I'll fix this.
fetcher.go
Outdated
| @@ -86,6 +87,11 @@ func (p *pool) doFetch(ctx context.Context, from string, c cid.Cid, attempt int) | |||
|
|
|||
| // TODO Refactor to use a metrics collector that separates the collection of metrics from the actual fetching | |||
| func (p *pool) fetchResource(ctx context.Context, from string, resource string, mime string, attempt int, cb DataCallback) (rm tieredhashing.ResponseMetrics, err error) { | |||
| isRange := "no" | |||
| if strings.Contains(resource, "bytes") { | |||
There was a problem hiding this comment.
- should we parse the URL and make sure there's a query parameter with the name?
- the name should be
entity-bytesnot bytes, right?
aarshkshah1992
force-pushed
the
feat/better-instrument-response-read-failures
branch
from
ddbfa4c to
756d8e0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.