Add version tables and deal eligibility criteria to Spark RSR documentation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
requested review from
juliangruber,
BigLep and
patrickwoodhead
and removed request for
juliangruber
|
Testing to see if this works for notifying: @space-meridian/spark |
BigLep
added a commit
to filecoin-project/github-mgmt
that referenced
this pull request
Nov 22, 2024
Add a space-meridian team for @mentioning per filecoin-project/service-classes#9
4 tasks
BigLep
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Looks good to me
I did a couple of small updates in 5350573
With github you can't @mention across organizations. I created @filecoin-project/space-meridian in filecoin-project/github-mgmt#87
|
Feel free to squash and merge |
LGTM, thanks!
Yeah, it's a bit annoying that team mentions don't work across organizations. Thank you for creating a new team inside the filecoin-project org! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close space-meridian/roadmap#196