-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: summarizing how network upgrades impact Lotus and its key dependencies #12481
Conversation
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
@Stebalien or @rvagg : @rjan90 and I were speaking and we didn't have full clarity on the filecoin-ffi → go-state-types dependency. I see filecoin-ffi has a go.mod dependency on it, but the update dependency flow that @rjan90 uses doesn't involve making a go-state-type update to filecoin-ffi. Could you please shed some light so we could get this documented? |
filecoin-ffi uses the following types from go-state-types:
Most of the time we don't break these, so it's going to typically be safe to not upgrade filecoin-ffi's version of gst. It was important last time because we introduced a new proof type. Probably it's a good idea to get it updated at least when we have a final go-state-types cut, but for most upgrades it may not be critical to put it in the workflow, maybe we can reduce some complexity by leaving it out until the very end when we get a final non-dev, non-rc tag. But where we are introducing new basic types, such as new proof variants, then we'll need to get it updated during the whole dev & rc cycle. |
Thanks @rvagg. I'll update docs accordingly. |
nothing so elegant tbh, I figured out all of the imports with a basic |
This includes some followups/learnings #12481.
@rjan90 : I think this is good to go. I added back the ffi dependency on go-state-types. I also did a followup PR (#12524 ) currently targeting this PR but it could switch to master after this PR merges. It includes more discussion on the ffi dependency on go-state-types plus other things I was clueing into from thinking about this more and reviewing what was done for nv24 skeleton. This also triggered some updates to https://docs.google.com/document/d/1KKJj2COb0vIqAQh-4F7fflJjxiTgGrU9oT9B461nsgg/edit which I @mentioned you on. |
* docs: summarizing how network upgrades impact Lotus and its key dependencies * Formatting updates * formatting * added diagram * Moved diagram up * Update LOTUS_RELEASE_FLOW.md Co-authored-by: Phi-rjan <[email protected]> * Update documentation/misc/Building_a_network_skeleton.md Co-authored-by: Phi-rjan <[email protected]> * Update documentation/misc/Building_a_network_skeleton.md Co-authored-by: Phi-rjan <[email protected]> * Update documentation/misc/Building_a_network_skeleton.md Co-authored-by: Phi-rjan <[email protected]> * Adding rust-filecoin-proofs-api and removing go-state-types dependency from ffi * typos * Added go-state-types back in as a dependency of ffi. * docs: update network skeleton docs based on nv24 learnings This includes some followups/learnings #12481. * cleanups * formatting * Update documentation/misc/Building_a_network_skeleton.md --------- Co-authored-by: Phi-rjan <[email protected]>
This is an attempt to summarize the relationships between Lotus and its key dependencies that are affected during a network upgrade. Some of this came out of discussing version schemes in filecoin-project/filecoin-ffi#468.
Checklist
Before you mark the PR ready for review, please make sure that: