Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize rebroadcast backoff #635

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Randomize rebroadcast backoff #635

merged 2 commits into from
Sep 6, 2024

Conversation

Stebalien
Copy link
Member

This fixes part of #549 to avoid having the entire network slam pubsub at the same time, although we should still optimize what we rebroadcast.

This also fixes the backoff calculator to return the actual backoff instead of always returning the max (oops).

@Stebalien Stebalien requested a review from masih September 5, 2024 20:56
@Stebalien
Copy link
Member Author

The remaining part of #549 is to limit our rebroadcast to the last 2 rounds, IIRC?

@Stebalien
Copy link
Member Author

Nah, nevermind. We only broadcast from the last 2 rounds. It's not worth it to optimize more.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (ca3d33a) to head (527e9c5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   79.78%   79.64%   -0.15%     
==========================================
  Files          52       52              
  Lines        4689     4691       +2     
==========================================
- Hits         3741     3736       -5     
- Misses        594      599       +5     
- Partials      354      356       +2     
Files with missing lines Coverage Δ
gpbft/options.go 66.66% <100.00%> (+0.62%) ⬆️
manifest/manifest.go 58.77% <100.00%> (+0.31%) ⬆️

... and 4 files with indirect coverage changes

gpbft/options.go Outdated Show resolved Hide resolved
gpbft/options.go Show resolved Hide resolved
gpbft/options.go Outdated Show resolved Hide resolved
@masih
Copy link
Member

masih commented Sep 6, 2024

We only broadcast from the last 2 rounds

Right, it is already limited to the latest 2 rounds.

@Stebalien Stebalien force-pushed the steb/backoff-randomize branch from 360911b to 1bd83a9 Compare September 6, 2024 16:25
@Stebalien Stebalien force-pushed the steb/backoff-randomize branch from 1bd83a9 to 527e9c5 Compare September 6, 2024 16:25
@Stebalien Stebalien enabled auto-merge September 6, 2024 16:25
@Stebalien Stebalien added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 03338aa Sep 6, 2024
13 checks passed
@Stebalien Stebalien deleted the steb/backoff-randomize branch September 6, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants