Rename the term Ticket Quality to Ticket Rank for better readability #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Converge ticket selection mechanism previously used the term "quality" to determine which ticket is better where the lower the quality value the better the ticket.
Additionally, the term "quality" is already used in GPBFT for
QUALITY
phase, which is a totally different thing.To avoid terminology confusion, and for a more intuitive notion in the context of ticket selection use the term "rank" instead, where instead one would say: whichever ticket ranks first is better, i.e. the smaller the value of rank the better the ticket.
While at it, update the docs on the compute function.