Test sway at commit and converge for unseen candidates

[masih]

Test that a participant sways for unseen candidates at COMMIT and CONVERGE.

Part of #237

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (a4deda5) to head (cb6794a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
emulator/host.go	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   79.76%   79.50%   -0.27%     
==========================================
  Files          52       52              
  Lines        4676     4689      +13     
==========================================
- Hits         3730     3728       -2     
- Misses        593      604      +11     
- Partials      353      357       +4     

Files with missing lines	Coverage Δ
emulator/driver.go	88.37% <100.00%> (+0.56%)	⬆️
emulator/driver_assertions.go	100.00% <100.00%> (ø)
gpbft/ticket_rank.go	84.61% <ø> (ø)
emulator/host.go	77.77% <71.42%> (-1.17%)	⬇️

... and 6 files with indirect coverage changes

[Kubuxu]

The codecov claims that CONVERGE sway is not hit.

[masih]

OK this is ready for another look; please let me know if you can think of a simpler way to test sway at CONVERGE. thanks

[Kubuxu]

What is the source of non-determinism? I think it should be only the chain seed, which leads to beacons.

[masih]

What is the source of non-determinism?

Order of chainsupport map for committed state, and consequently candidate inclusion in tryConverge which determines whether we sway at CONVERGE or not.

[Kubuxu]

Order of chainsupport map for committed state

That seems counter to the comment there, as the comment states that there should be only one.

[masih]

That seems counter to the comment there, as the comment states that there should be only one.

Right. If i have not missed anything I think that would only hold if this is fixed.