Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exponentialBackoffer overflowing into negative, bump protocol version #516

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Jul 24, 2024

At back-off number 84 (~42minuntes with no progress), the backoffer would return negative duration.

@Kubuxu Kubuxu force-pushed the fix/exponential-backoff branch from 27b2a77 to 74d3fa1 Compare July 24, 2024 15:34
@Kubuxu Kubuxu changed the title Fix exponentialBackoffer overflowing into negative Fix exponentialBackoffer overflowing into negative, bump protocol version Jul 24, 2024
Kubuxu added 2 commits July 24, 2024 17:37
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu force-pushed the fix/exponential-backoff branch from 748f392 to 05aa0fd Compare July 24, 2024 15:37
@Kubuxu Kubuxu enabled auto-merge July 24, 2024 15:38
Copy link

Suggested version: 0.0.6

Comparing to: v0.0.5 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# diagnostics
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.0.6

gocompat says:

HEAD is now at 660547c Release `v0.0.5` (#492)
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@Kubuxu Kubuxu added this pull request to the merge queue Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (660547c) to head (05aa0fd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   79.74%   79.67%   -0.08%     
==========================================
  Files          43       43              
  Lines        4074     4074              
==========================================
- Hits         3249     3246       -3     
- Misses        493      495       +2     
- Partials      332      333       +1     
Files Coverage Δ
gpbft/options.go 76.74% <100.00%> (ø)
manifest/manifest.go 59.82% <100.00%> (ø)

... and 2 files with indirect coverage changes

Merged via the queue into main with commit 41e850b Jul 24, 2024
14 of 15 checks passed
@Kubuxu Kubuxu deleted the fix/exponential-backoff branch July 24, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants