Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Making the carousel use translate3d instead of normal position CSS #128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Making the carousel use translate3d instead of normal position CSS #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8aa11d
Replace 'left' css tag to translate3d for better mobile performance
geooot Jun 20, 2016
7cbcb09
added translate3d to make stuff smoother on mobile browsers
geooot Jun 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/responsive-carousel.drag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
if( $( e.target ).attr( "data-transition" ) === "slide" ){
var activeSlides = getActiveSlides( $( e.target ), data.deltaX );

activeSlides[ 0 ].css( "left", data.deltaX + "px" );
activeSlides[ 1 ].css( "left", data.deltaX < 0 ? data.w + data.deltaX + "px" : -data.w + data.deltaX + "px" );
activeSlides[ 0 ].css( "transform", "translate3d(" + (data.deltaX + "px,0px,0px)") );
activeSlides[ 1 ].css( "transform", "translate3d(" + (data.deltaX < 0 ? data.w + data.deltaX + "px,0px,0px)" : -data.w + data.deltaX + "px,0px,0px)" ));
}
} )
.bind( pluginName + ".dragend", function( e, data ){
Expand All @@ -51,17 +51,17 @@

if( $( e.target ).attr( "data-transition" ) === "slide" ){
$( e.target ).one( navigator.userAgent.indexOf( "AppleWebKit" ) ? "webkitTransitionEnd" : "transitionEnd", function(){
activeSlides[ 0 ].add( activeSlides[ 1 ] ).css( "left", "" );
activeSlides[ 0 ].add( activeSlides[ 1 ] ).css( "transform", "" );
$( e.target ).trigger( "goto." + pluginName, activeSlides[ newSlide ? 1 : 0 ] );
});

if( newSlide ){
activeSlides[ 0 ].removeClass( activeClass ).css( "left", data.deltaX > 0 ? data.w + "px" : -data.w + "px" );
activeSlides[ 1 ].addClass( activeClass ).css( "left", 0 );
activeSlides[ 0 ].removeClass( activeClass ).css( "transform", "translate3d(" + (data.deltaX > 0 ? data.w + "px" : -data.w + "px,0px,0px)") );
activeSlides[ 1 ].addClass( activeClass ).css( "transform", "translate3d(0,0,0)" );
}
else {
activeSlides[ 0 ].css( "left", 0);
activeSlides[ 1 ].css( "left", data.deltaX > 0 ? -data.w + "px" : data.w + "px" );
activeSlides[ 0 ].css( "transform", "translate3d(0,0,0)");
activeSlides[ 1 ].css( "transform", "translate3d(" + (data.deltaX > 0 ? -data.w + "px" : data.w + "px,0px,0px)") );
}
}
else if( newSlide ){
Expand Down
32 changes: 16 additions & 16 deletions src/responsive-carousel.slide.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@
}
.carousel-slide .carousel-item {
position: absolute;
left: 100%;
transform: translate3d(100%, 0px, 0px);
top: 0;
width: 100%; /* necessary for non-active slides */
display: block; /* overrides basic carousel styles */
z-index: 1;
-webkit-transition: left .2s ease;
-moz-transition: left .2s ease;
-ms-transition: left .2s ease;
-o-transition: left .2s ease;
transition: left .2s ease;
-webkit-transition: transform .2s ease;
-moz-transition: transform .2s ease;
-ms-transition: transform .2s ease;
-o-transition: transform .2s ease;
transition: transform .2s ease;
}
.carousel-no-transition .carousel-item {
-webkit-transition: none;
Expand All @@ -35,27 +35,27 @@
transition: none;
}
.carousel-slide .carousel-active {
left: 0;
transform: translate3d(0, 0, 0);
position: relative;
z-index: 2;
}
.carousel-slide .carousel-in {
left: 0;
transform: translate3d(0, 0, 0);
}
.carousel-slide-reverse .carousel-out {
left: 100%;
transform: translate3d(100%, 0, 0);
}
.carousel-slide .carousel-out,
.carousel-slide-reverse .carousel-in {
left: -100%;
transform: translate3d(-100%, 0, 0);
}
.carousel-slide-reverse .carousel-item {
-webkit-transition: left .1s ease;
-moz-transition: left .1s ease;
-ms-transition: left .1s ease;
-o-transition: left .1s ease;
transition: left .1s ease;
-webkit-transition: transform .1s ease;
-moz-transition: transform .1s ease;
-ms-transition: transform .1s ease;
-o-transition: transform .1s ease;
transition: transform .1s ease;
}
.carousel-slide-reverse .carousel-active {
left: 0;
transform: translate3d(0, 0, 0);
}
4 changes: 0 additions & 4 deletions test/functional/slide.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@
<div>
<img src="../assets/monks.jpg">
</div>
<div>
<img src="../assets/monkey.jpg">
</div>

</div>


Expand Down