Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for changed PHP PPA repository #570

Merged
merged 3 commits into from
May 2, 2017
Merged

Fix for changed PHP PPA repository #570

merged 3 commits into from
May 2, 2017

Conversation

Repox
Copy link
Contributor

@Repox Repox commented Dec 9, 2016

This pull request addresses issue #568 and #569

@Repox
Copy link
Contributor Author

Repox commented Dec 9, 2016

If someone wants to start using the fix, change the Vagrantfile's Github config settings to the following:

# Config Github Settings
github_username = "Repox"
github_repo     = "Vaprobash"
github_branch   = "feature/phpppa"
github_url      = "https://raw.githubusercontent.com/#{github_username}/#{github_repo}/#{github_branch}"

Currently, the available PHP versions are:

  • 5.5
  • 5.6
  • 7.0
  • 7.1

@bendubuisson
Copy link

Any chance of merging this PR please? been using Repox's fix in the mean time but it would be good to go back to "normal". @fideloper

Thanks!

@Repox
Copy link
Contributor Author

Repox commented Feb 27, 2017

I know you're busy, @fideloper , but it would be nice with some feedback on this.

It's hard to recommend Vaprobash in it's current state.

@edwinveldhuizen
Copy link

@fideloper please merge this pull request 😊

@fideloper
Copy link
Owner

Does look good, let's try it out.

In theory this entire thing should go to Ubuntu 16.04 version of this, but I don't have time to put the work into that unfortunately.

@fideloper fideloper merged commit 85bc149 into fideloper:master May 2, 2017
@Repox
Copy link
Contributor Author

Repox commented May 2, 2017

Thank you.

I'll take a look at bumping it to 16.04.

@bendubuisson
Copy link

bendubuisson commented May 3, 2017

5.5 is still broken (5.6 works)

vagrant@php55:~$ sudo apt-get install php5.5-cli
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Unable to locate package php5.5-cli
E: Couldn't find any package by regex 'php5.5-cli'

@bendubuisson
Copy link

from https://launchpad.net/~ondrej/+archive/ubuntu/php:

PLEASE DON'T USE PHP 5.4 OR PHP 5.5. The PHP 5.5 and later are no longer supported with security updates, therefore they are not included in this repository.

@Repox
Copy link
Contributor Author

Repox commented May 3, 2017

At the time when I created the pull request, 5.5 worked, but I do see that this isn't the case anymore.

I'll have to update the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants