Remove code-path for responding to Delete events #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we are setting ownerReferences on the created objects kubernetes will take care of deleting them for us when the application is deleted, so we can remove all the code related to that. The delete methods for service, ingress and autoscaler are still needed for the case where the config changes such that they are no longer required, but now they can be private/internal methods.
mortenlj
previously approved these changes
May 28, 2020
oyvindio
requested changes
May 29, 2020
There was a problem hiding this comment.
I think this codepath can also be removed:
fiaas-deploy-daemon/fiaas_deploy_daemon/deployer/deploy.py
Lines 50 to 51 in f4cd341
mortenlj
approved these changes
May 29, 2020
|
Thanks for the reviews. As mentioned elsewhere, I'll wait on merging this until we are ready to trigger re-deploys of the apps in our clusters, I think it's relatively harmless being there and doing nothing in the short-term. |
|
Would be nice to just get this merged and out of the way, wouldn't it? 🙂 |
|
I think this PR needs to be merged or closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are setting ownerReferences on the created objects
kubernetes will take care of deleting them for us when the application
is deleted, so we can remove all the code related to that.
The delete methods for service, ingress and autoscaler are still needed
for the case where the config changes such that they are no longer
required, but now they can be private/internal methods.