Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Require version flag on creation, remove default value #296

Merged
merged 1 commit into from
Apr 23, 2024
+2 −1
Merged

Postgres: Require version flag on creation, remove default value #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ postgres=#
postgresCreateCmd.Flags().StringP("project", "", "", "project of the database")
postgresCreateCmd.Flags().StringP("partition", "", "", "partition where the database should be created")
postgresCreateCmd.Flags().IntP("replicas", "", 1, "replicas of the database")
postgresCreateCmd.Flags().StringP("version", "", "12", "version of the database") // FIXME add possible values
postgresCreateCmd.Flags().StringP("version", "", "", "version of the database")
postgresCreateCmd.Flags().StringSliceP("sources", "", []string{"0.0.0.0/0"}, "networks which should be allowed to connect in CIDR notation")
postgresCreateCmd.Flags().StringSliceP("labels", "", []string{}, "labels to add to that postgres database")
postgresCreateCmd.Flags().StringP("cpu", "", "500m", "cpus for the database")
Expand All @@ -278,6 +278,7 @@ postgres=#
genericcli.Must(postgresCreateCmd.MarkFlagRequired("project"))
genericcli.Must(postgresCreateCmd.MarkFlagRequired("partition"))
genericcli.Must(postgresCreateCmd.MarkFlagRequired("backup-config"))
genericcli.Must(postgresCreateCmd.MarkFlagRequired("version"))
genericcli.Must(postgresCreateCmd.RegisterFlagCompletionFunc("project", c.comp.ProjectListCompletion))
genericcli.Must(postgresCreateCmd.RegisterFlagCompletionFunc("partition", c.comp.PostgresListPartitionsCompletion))
genericcli.Must(postgresCreateCmd.RegisterFlagCompletionFunc("version", c.comp.PostgresListVersionsCompletion))
Expand Down
Loading