Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship quality #140

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Relationship quality #140

wants to merge 18 commits into from

Conversation

julia221501
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for easynwk ready!

Name Link
🔨 Latest commit 49c55d2
🔍 Latest deploy log https://app.netlify.com/sites/easynwk/deploys/66ed8d659a2c930008394480
😎 Deploy Preview https://deploy-preview-140--easynwk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alterEdgeType: accessor<number>("edgeType"),
isConnectable: computed(() => isConnectable(props.alter as Alter)),
showQuality: computed(() => store.state.session.qualityRelationship),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modus Qualitäten als ViewSetting (in localstorage) oder in Session?

@@ -265,6 +370,8 @@ export default defineComponent({

const selectedRoleLabel = ref(props.alter?.role);

const newCheckboxModel = ref(false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused -> remove


<div v-if="showQuality" class="field is-horizontal">
<div class="field-label is-normal">
<label class="label">Informationell</label>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change order - same as in Leitfaden

@@ -167,6 +167,111 @@
</div>
</div>

<div v-if="showQuality" class="field is-horizontal">
<div class="field-label">
<label class="label" for="chk-new-checkbox">Konflikthaft</label>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translations to englisch

<g
v-for="mark in alteriMarks.filter(
(mark) =>
(emotional && mark.d.supportEmotional >= 1) ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

computed

<template>
<div class="panel">
<p class="panel-heading" @click.stop="isOpen = !isOpen">
<span>Soziale Unterstützung</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Übersetzung einbauen

toggleSocial: () => store.commit("session/toggle", "social"),
toggleMaterial: () => store.commit("session/toggle", "material"),
togglePractical: () => store.commit("session/toggle", "practical"),
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vereinfachen: state nur in session store speichern
statt den ref's ein computed aus der session
toggleIcon ist dann nicht mehr nötig

</span>
<span v-if="showQuality">Qualitäten aus</span>
<span v-else>Qualitäten an</span>
</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkbox statt toggle button

cognitive: boolean;
social: boolean;
material: boolean;
practical: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etwas sprechenderer Name zB filterEmotional

supportCognitive: number;
supportSocial: number;
supportMaterial: number;
supportPractical: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diese Gelegenheit noch nutzen um Variablen umzubenennen v.a. Linking

Copy link
Collaborator

@alex-rind alex-rind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition: übersetzt erst, wenn man auf und zu klappt, keine Ahnung warum

informational: "informational",
social: "social",
linking: "linking",
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a ref () necessary or can it be a constant?

social: accessor<number>("supportSocial"),
linking: accessor<number>("supportPractical"),
});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref() oder array of accessor's?

class="clickAble"
/>
{{ t("linking") }}: {{ alteriPractical }}
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant -> arrays and v-for

@@ -167,6 +167,41 @@
</div>
</div>

<div v-if="showQuality" class="field is-horizontal">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only alteri that are connected with ego (alterEdgeType = 1 or 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants