-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relationship quality #140
base: main
Are you sure you want to change the base?
Relationship quality #140
Conversation
✅ Deploy Preview for easynwk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # src/components/ViewOptionsPanel.vue # src/store/sessionModule.ts # src/views/HomeView.vue
alterEdgeType: accessor<number>("edgeType"), | ||
isConnectable: computed(() => isConnectable(props.alter as Alter)), | ||
showQuality: computed(() => store.state.session.qualityRelationship), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modus Qualitäten als ViewSetting (in localstorage) oder in Session?
@@ -265,6 +370,8 @@ export default defineComponent({ | |||
|
|||
const selectedRoleLabel = ref(props.alter?.role); | |||
|
|||
const newCheckboxModel = ref(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused -> remove
src/components/AlteriEditForm.vue
Outdated
|
||
<div v-if="showQuality" class="field is-horizontal"> | ||
<div class="field-label is-normal"> | ||
<label class="label">Informationell</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change order - same as in Leitfaden
src/components/AlteriEditForm.vue
Outdated
@@ -167,6 +167,111 @@ | |||
</div> | |||
</div> | |||
|
|||
<div v-if="showQuality" class="field is-horizontal"> | |||
<div class="field-label"> | |||
<label class="label" for="chk-new-checkbox">Konflikthaft</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translations to englisch
<g | ||
v-for="mark in alteriMarks.filter( | ||
(mark) => | ||
(emotional && mark.d.supportEmotional >= 1) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
computed
src/components/SupportPanel.vue
Outdated
<template> | ||
<div class="panel"> | ||
<p class="panel-heading" @click.stop="isOpen = !isOpen"> | ||
<span>Soziale Unterstützung</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Übersetzung einbauen
toggleSocial: () => store.commit("session/toggle", "social"), | ||
toggleMaterial: () => store.commit("session/toggle", "material"), | ||
togglePractical: () => store.commit("session/toggle", "practical"), | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vereinfachen: state nur in session store speichern
statt den ref's ein computed aus der session
toggleIcon ist dann nicht mehr nötig
</span> | ||
<span v-if="showQuality">Qualitäten aus</span> | ||
<span v-else>Qualitäten an</span> | ||
</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkbox statt toggle button
cognitive: boolean; | ||
social: boolean; | ||
material: boolean; | ||
practical: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
etwas sprechenderer Name zB filterEmotional
supportCognitive: number; | ||
supportSocial: number; | ||
supportMaterial: number; | ||
supportPractical: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diese Gelegenheit noch nutzen um Variablen umzubenennen v.a. Linking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in addition: übersetzt erst, wenn man auf und zu klappt, keine Ahnung warum
informational: "informational", | ||
social: "social", | ||
linking: "linking", | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is a ref () necessary or can it be a constant?
social: accessor<number>("supportSocial"), | ||
linking: accessor<number>("supportPractical"), | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref() oder array of accessor's?
class="clickAble" | ||
/> | ||
{{ t("linking") }}: {{ alteriPractical }} | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant -> arrays and v-for
src/components/AlteriEditForm.vue
Outdated
@@ -167,6 +167,41 @@ | |||
</div> | |||
</div> | |||
|
|||
<div v-if="showQuality" class="field is-horizontal"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only alteri that are connected with ego (alterEdgeType = 1 or 2)
…elemente nur angezeigt wenn Qualitäten an sind
No description provided.