Refactor and Add Rounds Controller #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhmurakami
force-pushed
the
feat/add-rounds-controller
branch
from
a7fac73 to
9fceb16
Compare
fhmurakami
added a commit
that referenced
this pull request
Dec 29, 2024
* Add RoundsController * Add views tests for round * Refactor Finish service * Add specs for Round::StartService * Add specs for Round::NextEquationService * Add specs for Round::SubmitAnswerService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new RoundsController to encapsulate the logic related to rounds. The following changes were made:
Added a new RoundsController to handle round-related requests
Moved relevant logic from CollectionsController and HomeController to RoundsController
Moved views from Home and Collections to Rounds
Added tests for RoundsController, Rounds views, and Round services