This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
#69 Fixing 0.3.0 expect match issue when channel receives multiple lines … #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of strings at the same time
|
I think that was originally changed because checking the entire output everytime caused it to time out? #63 |
zebbarry
reviewed
Apr 12, 2021
paramiko_expect.py
Outdated
| @@ -188,7 +187,7 @@ def expect( | |||
|
|
|||
| # Add the currently read buffer to the output | |||
| self.current_output += current_buffer_decoded | |||
| current_buffer_output_decoded = '\n' + self.current_output.splitlines()[-1] | |||
| current_buffer_output_decoded = '\n' + current_buffer_decoded | |||
There was a problem hiding this comment.
Check the latest output for any matches instead of all the total output - Requires current_output_line = 0 to be initialized before the while loop
Suggested change
| current_buffer_output_decoded = '\n' + current_buffer_decoded | |
| # Add the currently read buffer to the output | |
| self.current_output += current_buffer_decoded | |
| output_lines = self.current_output.splitlines() | |
| # Check the latest output for any matches | |
| current_buffer_output_decoded = '\n' + '\n'.join(output_lines[current_output_line:]) | |
| # Update current line in output that has been checked | |
| current_output_line += len(output_lines[current_output_line:]) - 1 |
|
I just hit the issue and realized that the code fix proposed by @vinaykumar-c as it is should work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of strings at the same time