Override generated scenarios #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Dec 6, 2019
| module.exports = processOverrides; | ||
| function processOverrides(urls, scenarios) { | ||
|
|
||
| scenarios.forEach((scenario, scenarioKey) => { |
There was a problem hiding this comment.
I know that doing a forEach inside another forEach isn't ideal, but I haven't yet figured out a more efficient way to do this.
TI-dejesus
reviewed
Dec 6, 2019
ghost
marked this pull request as ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR probably needs a little work. I'm new to contributing to other people's projects, so criticism is welcome!
First of all, I had to update
nycandavato get the tests to run. Then I noticed two of the tests were failing because I'm running the project on my Windows machine. I updated the tests so that they are now Windows-compatible.Normally, backstop-crawl allows the user to define a
backstop.template.json, however, I wanted to ability to explicitly state which template file to use.I added the option to pass in a
--templateflag. If the path is invalid, an error will be shown. If the flag isn't provided, backstop-crawl behaves as usual.I also added functionality to process scenario overrides. If the user defines scenarios in their template, those will override generated scenarios with the same label.
If there are no matching labels, the override is ignored.
An idea I had that might be nice is to have overridden scenarios AND additional scenarios. I figured this could be tackled later.
This ticket resolves #30