Update data of user with same uuid in world (workadventure#2762)

Co-authored-by: grégoire parant <[email protected]>
ffddorf · Nov 2, 2022 · cc9bacc · cc9bacc
1 parent 4e011c5
commit cc9bacc
Showing 1 changed file with 40 additions and 31 deletions.
diff --git a/back/src/Model/User.ts b/back/src/Model/User.ts
@@ -224,6 +224,8 @@ export class User implements Movable {
                         setVariable.getPersist()
                     )
                     .catch((e) => console.error("An error occurred while saving world variable: ", e));
+
+                this.updateDataUserSameUUID(setVariable, details);
             } else if (scope === SetPlayerVariableMessage.Scope.ROOM) {
                 this.variables
                     .saveRoomVariable(
@@ -235,37 +237,7 @@ export class User implements Movable {
                     )
                     .catch((e) => console.error("An error occurred while saving room variable: ", e));
 
-                // Very special case: if we are updating a player variable AND if if the variable is persisted, we must also
-                // update the variable of all other users with the same UUID!
-                if (setVariable.getPersist()) {
-                    // Let's have a look at all other users sharing the same UUID
-                    const brothers = this.brothersFinder.getBrothers(this);
-                    for (const brother of brothers) {
-                        brother.variables
-                            .saveRoomVariable(
-                                setVariable.getName(),
-                                setVariable.getValue(),
-                                setVariable.getPublic(),
-                                setVariable.getTtl()?.getValue(),
-                                // We don't need to persist this for every player as this will write in the same place in DB.
-                                false
-                            )
-                            .catch((e) =>
-                                console.error(
-                                    "An error occurred while saving room variable for a user with same UUID: ",
-                                    e
-                                )
-                            );
-
-                        // Let's dispatch the message to the user.
-                        const playerDetailsUpdatedMessage = new PlayerDetailsUpdatedMessage();
-                        playerDetailsUpdatedMessage.setUserid(brother.id);
-                        playerDetailsUpdatedMessage.setDetails(details);
-                        const subMessage = new SubMessage();
-                        subMessage.setPlayerdetailsupdatedmessage(playerDetailsUpdatedMessage);
-                        brother.emitInBatch(subMessage);
-                    }
-                }
+                this.updateDataUserSameUUID(setVariable, details);
             } else {
                 const _exhaustiveCheck: never = scope;
             }
@@ -291,4 +263,41 @@ export class User implements Movable {
     public getVariables(): PlayerVariables {
         return this.variables;
     }
+
+    private updateDataUserSameUUID(
+        setVariable: SetPlayerVariableMessage,
+        details: SetPlayerDetailsMessage | undefined
+    ) {
+        // Very special case: if we are updating a player variable AND if if the variable is persisted, we must also
+        // update the variable of all other users with the same UUID!
+        console.log("GET PERSIST", setVariable.getPersist());
+        if (setVariable.getPersist()) {
+            // Let's have a look at all other users sharing the same UUID
+            const brothers = this.brothersFinder.getBrothers(this);
+            console.log("BROTHERS", brothers);
+
+            for (const brother of brothers) {
+                brother.variables
+                    .saveRoomVariable(
+                        setVariable.getName(),
+                        setVariable.getValue(),
+                        setVariable.getPublic(),
+                        setVariable.getTtl()?.getValue(),
+                        // We don't need to persist this for every player as this will write in the same place in DB.
+                        false
+                    )
+                    .catch((e) =>
+                        console.error("An error occurred while saving room variable for a user with same UUID: ", e)
+                    );
+
+                // Let's dispatch the message to the user.
+                const playerDetailsUpdatedMessage = new PlayerDetailsUpdatedMessage();
+                playerDetailsUpdatedMessage.setUserid(brother.id);
+                playerDetailsUpdatedMessage.setDetails(details);
+                const subMessage = new SubMessage();
+                subMessage.setPlayerdetailsupdatedmessage(playerDetailsUpdatedMessage);
+                brother.emitInBatch(subMessage);
+            }
+        }
+    }
 }