Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk type to match clone source #11

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix disk type to match clone source #11

merged 1 commit into from
Jan 21, 2024

Conversation

mraerino
Copy link
Member

@mraerino mraerino commented Jan 21, 2024

It seems that if this doesn't match the disk type of the template VM we're cloning from that there are two disk entries. That seems bad.

This comment has been minimized.

Copy link

🏗️ Terraform Plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.supernode[0].proxmox_vm_qemu.supernode is tainted, so must be replaced
-/+ resource "proxmox_vm_qemu" "supernode" {
      - ciuser                    = "admin" -> null
      + default_ipv4_address      = (known after apply)
      ~ define_connection_info    = true -> false
      - disk_gb                   = 0 -> null
      ~ id                        = "pm2/qemu/119" -> (known after apply)
        name                      = "supernode-dev-0"
      + nameserver                = (known after apply)
      - qemu_os                   = "other" -> null
      ~ reboot_required           = false -> (known after apply)
      + searchdomain              = (known after apply)
      + ssh_host                  = (known after apply)
      + ssh_port                  = (known after apply)
      ~ unused_disk               = [] -> (known after apply)
      + vmid                      = (known after apply)
        # (32 unchanged attributes hidden)

      ~ disk {
          ~ file               = "base-9001-disk-0/vm-119-disk-0" -> (known after apply)
          ~ format             = "raw" -> (known after apply)
          + media              = (known after apply)
          ~ size               = "2G" -> "4G"
          ~ slot               = 0 -> (known after apply)
          ~ storage_type       = "rbd" -> (known after apply)
          ~ volume             = "system:base-9001-disk-0/vm-119-disk-0" -> (known after apply)
            # (21 unchanged attributes hidden)
        }

      ~ network {
          ~ macaddr   = "3A:93:C3:E3:2D:82" -> (known after apply)
          - mtu       = 0 -> null
          ~ queues    = 0 -> (known after apply)
          ~ rate      = 0 -> (known after apply)
            # (5 unchanged attributes hidden)
        }

        # (2 unchanged blocks hidden)
    }

  # module.supernode[1].proxmox_vm_qemu.supernode is tainted, so must be replaced
-/+ resource "proxmox_vm_qemu" "supernode" {
      - ciuser                    = "admin" -> null
      + default_ipv4_address      = (known after apply)
      ~ define_connection_info    = true -> false
      - disk_gb                   = 0 -> null
      ~ id                        = "pm2/qemu/120" -> (known after apply)
        name                      = "supernode-dev-1"
      + nameserver                = (known after apply)
      - qemu_os                   = "other" -> null
      ~ reboot_required           = false -> (known after apply)
      + searchdomain              = (known after apply)
      + ssh_host                  = (known after apply)
      + ssh_port                  = (known after apply)
      ~ unused_disk               = [] -> (known after apply)
      + vmid                      = (known after apply)
        # (32 unchanged attributes hidden)

      ~ disk {
          ~ file               = "base-9001-disk-0/vm-120-disk-0" -> (known after apply)
          ~ format             = "raw" -> (known after apply)
          + media              = (known after apply)
          ~ slot               = 0 -> (known after apply)
          ~ storage_type       = "rbd" -> (known after apply)
          ~ type               = "virtio" -> "scsi"
          ~ volume             = "system:base-9001-disk-0/vm-120-disk-0" -> (known after apply)
            # (21 unchanged attributes hidden)
        }

      ~ network {
          ~ macaddr   = "8E:AA:CE:5D:01:61" -> (known after apply)
          - mtu       = 0 -> null
          ~ queues    = 0 -> (known after apply)
          ~ rate      = 0 -> (known after apply)
            # (5 unchanged attributes hidden)
        }

        # (2 unchanged blocks hidden)
    }

Plan: 2 to add, 0 to change, 2 to destroy.

@mraerino mraerino merged commit 5d4b0f2 into main Jan 21, 2024
2 checks passed
@mraerino mraerino deleted the fix/disk-type branch January 21, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant