Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #4

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test #4

wants to merge 1 commit into from

Conversation

Djfe
Copy link
Member

@Djfe Djfe commented Jul 22, 2024

Ich muss das morgen nochmal alles sauber committen. Hier erstmal die Änderungen zum Reviewen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not change the defaults, it is overwritten in the correct place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can change it there:

firmware_changelog: "https://github.com/ffac/site/blob/v2023.1.x/CHANGELOG.md"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be included in this commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it should be a separate commit, as it does not have anything to do with the devices.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants