Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the new dt-blob structure #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pelwell
Copy link

@pelwell pelwell commented Jun 3, 2015

As described in #5, here is a suitably updated dt-blob.dts

@pelwell
Copy link
Author

pelwell commented Jun 3, 2015

Something like that?

@6by9
Copy link

6by9 commented Jun 3, 2015

Looks good - I owe you a beer or two :-)

What's the situation with LAN_RESET being renamed to LAN_RUN? It appears to have changed in the same firmware release that added all the other platforms, in which case it isn't needed in the new platform name blocks as there is no firmware that will look for it under the new blocks.

@pelwell
Copy link
Author

pelwell commented Jun 3, 2015

It was noticed that the name didn't match the schematic signal and also didn't make it clear that it was and active low reset.

@6by9
Copy link

6by9 commented Jun 3, 2015

OK, but does it need to be added back to all the new platform names? It's needed for the old ones, but I don't think it is on the new ones.

@pelwell
Copy link
Author

pelwell commented Jun 3, 2015

Feel free to delete them.

@6by9
Copy link

6by9 commented Jun 3, 2015

I was just trying to work out if there was actually a need for them - clean code and all that. Sorry to have been hassling :-(
I'll double check on dpi666 branch with old and new firmwares and report back/update the patches if necessary.

The old pins_bplus configuration is retained for
backwards compatibility.
@6by9
Copy link

6by9 commented Jun 3, 2015

Ta muchly. All seems very happy on old and new firmwares.
Just sorting out a PR for dpi666. Will need to ping Adafruit too as they are hosting a precompiled blob for the Kippah which won't work with the latest firmware.

@gertvanloo
Copy link
Contributor

Phil,
than you for replying to this on Github.

-- Gert

On 03/06/2015 16:41, Phil Elwell wrote:

Feel free to delete them.


Reply to this email directly or view it on GitHub:
#6 (comment)

@AndrewFromMelbourne
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants