-
Notifications
You must be signed in to change notification settings - Fork 88
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More work on plumbing attribute accumulation through (#263)
* Plumb bounding boxes through potential intersections * Quick bbox reject for bins that can't possibly intersect * Inching toward attribute accumulation in megatile handling * Some sort of test for how all these things interact with each other. Automatic numeric attribute accumulation does *not* apply to attributes that have an explicit attribute accumulator set, because the order of operations is too messy and weird * More sketching * More sketching * Actually do some accumulation * Put all that behind an --accumulate-numeric flag * Use the same attribute accumulation logic in binning as in megatiles * Fix backwards conditional * Add means, but somehow I have some counts of 0 * Handle aggregated attributes with no base attribute in the feature * Checkpoint before I break everything * Found a flaw, now to debug * Fix a typo that broke accumulation * Add binning tests * Make sure IDs make it through on the bins * Fix count/mean accumulation * Make the numeric accumulation prefix configurable * Make sure the accumulate test still works with a different prefix * Forgot to update this test * More testing to make sure cluster sizes make it all the way through * Fix neglected --accumulate-attribute when binning * Mark unexercised attribute accumulation cases as "can't happen" * Factor out numeric preservation * Attrs with the accumulation prefix are just preserved, not accumulated * Test behavior of prefixed attributes * Plumbing for exclude and exclude-prefix * Implement and test attribute prefix stripping in overzoom * Update version and changelog * For debugging, make an attribute list of source feature IDs * Revert "For debugging, make an attribute list of source feature IDs" This reverts commit 65fc99c.
- Loading branch information
Showing
23 changed files
with
2,387 additions
and
3,920 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.