Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to upload empty vector layers, support xyz layers #51

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Don't try to upload empty vector layers, support xyz layers #51

merged 3 commits into from
Nov 21, 2023

Conversation

nyalldawson
Copy link
Collaborator

No description provided.

@nyalldawson nyalldawson force-pushed the no_upload_empty branch 2 times, most recently from 0521ab2 to 75677e5 Compare November 21, 2023 03:24
@nyalldawson nyalldawson changed the title Don't try to upload empty vector layers Don't try to upload empty vector layers, support xyz layers Nov 21, 2023
doorgan
doorgan approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@doorgan doorgan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to upload a vector layer with no features causes the layer to not be uploaded to Felt, as expected

I think this is good to merge after conflict resolution

@nyalldawson
Don't try to upload empty vector layers
838ff4c
@nyalldawson
Report data provider for unsupported layers
6b68ed0 
And ensure we don't include empty layer details in usage reports
@nyalldawson
Add support for (some) XYZ tile layers
2bd4748 
Take care to catch unsuported {q} token in layer uris
@nyalldawson nyalldawson merged commit b6796a2 into main Nov 21, 2023
11 checks passed
@nyalldawson nyalldawson deleted the no_upload_empty branch November 21, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doorgan doorgan doorgan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyalldawson @doorgan