Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(serializer): Account for Required and Enum Properties #9

Merged
merged 3 commits into from
May 23, 2024
Merged

Fix(serializer): Account for Required and Enum Properties #9

merged 3 commits into from
May 23, 2024

Conversation

kyleVsteger
Copy link
Contributor

Why am I opening this PR?

I introduced the schema_path: "shared/channel_schema.json" option to our UserSocket and was failing to generate the schema. These changes fixed the issue and generates valid JSON schema

doorgan
doorgan approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working, and thanks for the test!

@doorgan doorgan merged commit 47c49b6 into main May 23, 2024
6 checks passed
@doorgan doorgan deleted the fix-enum-and-required branch May 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doorgan doorgan doorgan approved these changes

Assignees

@doorgan doorgan

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyleVsteger @doorgan