Improve assert_reply error messages #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the error assertions happen directly on _all_ the messages that the channel has received, when we only very specifically care about the specific reply to our message. This PR splits that assertion into two steps, the first step gets the reply, and the second step asserts on the expected status and reply. They are asserted together so that when there's an error you get detailed information about what the error payload is, otherwise your initial test failure may simply tell you something like ":ok does not equal :error"
doorgan
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the error assertions happen directly on all the messages that the channel has received, when we only very specifically care about the specific reply to our message.
This PR splits that assertion into two steps, the first step gets the reply, and the second step asserts on the expected status and reply. They are asserted together so that when there's an error you get detailed information about what the error payload is, otherwise your initial test failure may simply tell you something like ":ok does not equal :error"