Wrap deprecated and unsupported types rather than calling error.
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 81.28% 81.23% -0.05%
==========================================
Files 11 11
Lines 1651 1652 +1
==========================================
Hits 1342 1342
- Misses 309 310 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an old database containing some deprecated
undefinedvalues that break queries. I do not want to modify the data.I considered adding support for BSON_TYPE_UNDEFINED but this is a simpler, more general solution. It gives users the option of converting BSONUnsupported(BSON_TYPE_UNDEFINED) to missing or nothing.
It will allow BSON_TYPE_REGEX values (which are unsupported, not deprecated) to not break queries, though the data is lost. It would be nice to be able to use Julia regex in queries...